Really fix the maxwell perf regression this time#1920
Merged
ericniebler merged 2 commits intoNVIDIA:mainfrom Mar 7, 2026
Merged
Conversation
ericniebler
force-pushed
the
really-fix-the-maxwell-perf-regression-this-time
branch
4 times, most recently
from
0a204cf to
6347b9c
Compare
ericniebler
force-pushed
the
really-fix-the-maxwell-perf-regression-this-time
branch
from
6347b9c to
f5d7bcc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stream_domain::transform_senderwas only accepting__tuple-based sender types like__sexpr. this PR generalizesstream_domain::transform_senderto accept anything that can be used to initialize a structured binding, to the best of the compiler's ability.note: on gcc/clang we use the
__builtin_structured_binding_sizebuiltin. on other compilers, we recognize senders based on__tupleorstd::tuple, or any type that has specializedSTDEXEC::__structured_binding_size_v(in __sender_introspection.hpp) to a value other than-1.if structured bindings can introduce a pack (C++26), then senders with an arbitrary number of children are supported. otherwise, the limit is fixed to 8 child senders.